Comments on: Useless Unit Test http://RandyPatterson.com/index.php/2007/09/21/useless-unit-test/ Code To Live, Live To Code Wed, 08 Sep 2010 06:25:33 -0400 http://wordpress.org/?v=2.8.4 hourly 1 By: Richard http://RandyPatterson.com/index.php/2007/09/21/useless-unit-test/comment-page-1/#comment-38 Richard Mon, 03 Mar 2008 19:53:41 +0000 http://localhost/2007/09/21/UselessUnitTest.aspx#comment-38 This unit test should be testing the DAL based of the code shown. What you are describing "testing business logic" should be a separate unit test. This unit test has many advantages such as testing the SQL or Stored Procedure that were associated with this call, Verifying that the code can still reach the server, Verifying the code still has permissions to preform the action in question, etc... The business logic code isn't suppose to sit in the DAL so this test by nature doesn't focus on business logic. If you search around there is probably another test somewhere that test against business logic and leaves the DAL out of the equation. This unit test should be testing the DAL based of the code shown. What you are describing "testing business logic" should be a separate unit test. This unit test has many advantages such as testing the SQL or Stored Procedure that were associated with this call, Verifying that the code can still reach the server, Verifying the code still has permissions to preform the action in question, etc…

The business logic code isn’t suppose to sit in the DAL so this test by nature doesn’t focus on business logic. If you search around there is probably another test somewhere that test against business logic and leaves the DAL out of the equation.

]]> By: Jeff Odell http://RandyPatterson.com/index.php/2007/09/21/useless-unit-test/comment-page-1/#comment-37 Jeff Odell Thu, 01 Nov 2007 00:19:50 +0000 http://localhost/2007/09/21/UselessUnitTest.aspx#comment-37 I would argue this is an Integration Test, not a Unit Test. Hope I didn't write it! I would argue this is an Integration Test, not a Unit Test. Hope I didn’t write it!

]]> By: Roy Lawson http://RandyPatterson.com/index.php/2007/09/21/useless-unit-test/comment-page-1/#comment-36 Roy Lawson Sun, 23 Sep 2007 00:42:05 +0000 http://localhost/2007/09/21/UselessUnitTest.aspx#comment-36 I would be OK with these unit tests if they were generated - many orm generators (nettiers for one) generate unit tests for the DAL. But, given that the DAL is often a moving target I wouldn't want to manually create and update these unit tests. It's more trouble than it's worth. Your time would be better spent unit testing the business logic. I would be OK with these unit tests if they were generated – many orm generators (nettiers for one) generate unit tests for the DAL.

But, given that the DAL is often a moving target I wouldn’t want to manually create and update these unit tests. It’s more trouble than it’s worth. Your time would be better spent unit testing the business logic.

]]> By: Oleg Sych http://RandyPatterson.com/index.php/2007/09/21/useless-unit-test/comment-page-1/#comment-35 Oleg Sych Sat, 22 Sep 2007 19:17:42 +0000 http://localhost/2007/09/21/UselessUnitTest.aspx#comment-35 I could think of some problems such a useless unit test would help to detect, having been bitten by one just a few days ago. Somebody mistakenly renamed a stored proc in DAL. No big deal, but the problem went undetected for a while. I could think of some problems such a useless unit test would help to detect, having been bitten by one just a few days ago. Somebody mistakenly renamed a stored proc in DAL. No big deal, but the problem went undetected for a while.

]]> By: Anonymous http://RandyPatterson.com/index.php/2007/09/21/useless-unit-test/comment-page-1/#comment-34 Anonymous Fri, 21 Sep 2007 15:35:57 +0000 http://localhost/2007/09/21/UselessUnitTest.aspx#comment-34 OMG!!! OMG!!!

]]>